Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: bootstrapping with default pubsub topic #2031

Merged
merged 6 commits into from
Jun 6, 2024
Merged

fix: bootstrapping with default pubsub topic #2031

merged 6 commits into from
Jun 6, 2024

Conversation

danisharora099
Copy link
Collaborator

@danisharora099 danisharora099 commented Jun 4, 2024 •
edited
Loading

Problem

#2011

Solution

Use the wakuv2.prod fleet to bootstrap into DefaultPubsubTopic
https://discord.com/channels/1110799176264056863/1236947977252110346

Notes

@danisharora099 danisharora099 requested a review from a team as a code owner June 4, 2024 17:53
@danisharora099 danisharora099 mentioned this pull request Jun 4, 2024
Closed
3 tasks
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 4, 2024 •
edited
Loading

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
Waku node 181.63 KB (+0.13% 🔺) 3.7 s (+0.13% 🔺) 21.7 s (+135.6% 🔺) 25.3 s
Waku Simple Light Node 181.56 KB (+0.08% 🔺) 3.7 s (+0.08% 🔺) 14.7 s (-28.83% 🔽) 18.3 s
ECIES encryption 23.12 KB (0%) 463 ms (0%) 3.1 s (-46.02% 🔽) 3.5 s
Symmetric encryption 22.58 KB (0%) 452 ms (0%) 4.1 s (+34.2% 🔺) 4.5 s
DNS discovery 72.49 KB (0%) 1.5 s (0%) 7 s (-17.82% 🔽) 8.5 s
Peer Exchange discovery 74.15 KB (0%) 1.5 s (0%) 8 s (-10.51% 🔽) 9.5 s
Local Peer Cache Discovery 67.68 KB (0%) 1.4 s (0%) 9.5 s (-19.21% 🔽) 10.8 s
Privacy preserving protocols 38.87 KB (0%) 778 ms (0%) 5.1 s (+0.66% 🔺) 5.9 s
Waku Filter 111.92 KB (0%) 2.3 s (0%) 18.5 s (+50.65% 🔺) 20.7 s
Waku LightPush 110.39 KB (0%) 2.3 s (0%) 15.6 s (+6.14% 🔺) 17.8 s
History retrieval protocols 110.91 KB (0%) 2.3 s (0%) 11.1 s (+32.29% 🔺) 13.3 s
Deterministic Message Hashing 7.29 KB (0%) 146 ms (0%) 849 ms (-63.63% 🔽) 995 ms

weboko
weboko reviewed Jun 4, 2024
View reviewed changes
Copy link
Collaborator

@weboko weboko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the reason for moving to this PR from #2015 ?

I don't see it bringing any difference than new naming to enrtree.

@danisharora099
Copy link
Collaborator Author

danisharora099 commented Jun 5, 2024 •
edited
Loading

What is the reason for moving to this PR from #2015 ?

No major reason -- there was obfuscation by the comments/thread in the PR based on the misleading information re the fleets to be used. Much cleaner to branch off into a new PR. Deleted the branch.

weboko
weboko approved these changes Jun 6, 2024
View reviewed changes
Copy link
Collaborator

@weboko weboko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you again for root causing the problem with domains in the ENR.

@danisharora099 danisharora099 changed the title fix: bootstrapping into default pubsub topic fix: bootstrapping with default pubsub topic Jun 6, 2024
@danisharora099 danisharora099 merged commit 16e9116 into master Jun 6, 2024
11 of 13 checks passed
@danisharora099 danisharora099 deleted the feat/map-enrtree branch June 6, 2024 16:55
@weboko weboko mentioned this pull request May 30, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weboko weboko weboko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: map/use correct bootstrap nodes fleet according to the configured pubsub topic
2 participants
@danisharora099 @weboko